Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UV wrong #439

Closed
triansion opened this issue Jul 22, 2022 · 2 comments
Closed

UV wrong #439

triansion opened this issue Jul 22, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@triansion
Copy link

@atteneder Hello,I found another bug😂. When I manually import a GLB file whose UVs are quantized to Short format, its textures are displayed wrong.

This is wrong file's screenshot:
image

And this is right file's screenshot:
image

So I found ConvertUVsInt16ToFloatInterleavedNormalizedJob code has wrong in line 740:
image

Finally, it was working right after I fixed it like this:
image

So I think I need to remind you
😜

@triansion triansion added the bug Something isn't working label Jul 22, 2022
@atteneder
Copy link
Owner

@triansion Thanks, great find and fix. This only surfaced when the jobs package is installed and the job system decided to split it in batches.

One question though: Why didn't you consider making a PR?

@atteneder
Copy link
Owner

fixed in 4.8.4

@atteneder atteneder self-assigned this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants