New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to ipfs-chat and ipfs chunkstore #3691

Merged
merged 3 commits into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@willhite
Contributor

willhite commented Sep 11, 2017

  • Change ipfs paths to include directory where ipfs repo is stored.
  • Rework ipfs-chat to create ipfs chunkstores manually rather than
    relying on Spec.ForDataset. This enables creating two chunkstores
    (one local and one network) using the same IpfsNode (ipfs repo).
  • Create separate replicate function for daemon and mergeMessage
    function for client to experiment with slightly different behaviors
    for each.
@willhite

This comment has been minimized.

Show comment
Hide comment
@willhite

willhite Sep 11, 2017

Contributor

The PR contains the latest changes to the IPFS portions of the chat program. There's lots of code duplication between the ipfs and p2p parts of the program.

Contributor

willhite commented Sep 11, 2017

The PR contains the latest changes to the IPFS portions of the chat program. There's lots of code duplication between the ipfs and p2p parts of the program.

@willhite willhite requested a review from aboodman Sep 11, 2017

willhite added some commits Sep 11, 2017

Modifications to ipfs-chat and ipfs chunkstore
 * Change ipfs paths to include directory where ipfs repo is stored.
 * Rework ipfs-chat to create ipfs chunkstores manually rather than
   relying on Spec.ForDataset. This enables creating two chunkstores
   (one local and one network) using the same IpfsNode (ipfs repo).
 * Create separate replicate function for daemon and mergeMessage
   function for client to experiment with slightly different behaviors
   for each.
Re-organization of code to remove duplication.
The main points are:
* added event loop to process events synchronously
* more agressive about not re-processing msgs from other nodes
  that we've already processed
* fixed bug in ipfs chunkstore HasMany()

@aboodman aboodman merged commit 742f068 into attic-labs:master Sep 20, 2017

1 check passed

default Build finished.
Details
firstLayout = true
)
func CreateTermUI(events chan ChatEvent) TermUI {

This comment has been minimized.

@aboodman

aboodman Sep 20, 2017

Contributor

Don't you need to return *TermUI? Otherwise TermUI.InSearch will always be by value.

@aboodman

aboodman Sep 20, 2017

Contributor

Don't you need to return *TermUI? Otherwise TermUI.InSearch will always be by value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment