New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-longer-needed js implementation. #3705

Merged
merged 1 commit into from Sep 14, 2017

Conversation

Projects
None yet
2 participants
@wardn
Contributor

wardn commented Sep 14, 2017

Issue #3667
Brought up to date with commit 3cbaf56.
Mostly scripted out, so feel free to commit if/when convenient.

@arv

This comment has been minimized.

Show comment
Hide comment
@arv

arv Sep 14, 2017

Contributor

I would approve the removal of the js impl at this point. I'm opposed to changing the go structure at the moment.

Contributor

arv commented Sep 14, 2017

I would approve the removal of the js impl at this point. I'm opposed to changing the go structure at the moment.

@wardn

This comment has been minimized.

Show comment
Hide comment
@wardn

wardn Sep 14, 2017

Contributor

Splitting it up.

Contributor

wardn commented Sep 14, 2017

Splitting it up.

@wardn wardn changed the title from Remove no-longer-needed extraneous `go` subdirs to Remove no-longer-needed js implementation. Sep 14, 2017

@arv

This comment has been minimized.

Show comment
Hide comment
@arv

arv Sep 14, 2017

Contributor

jenkins: test this

Contributor

arv commented Sep 14, 2017

jenkins: test this

@arv arv self-requested a review Sep 14, 2017

@arv

arv approved these changes Sep 14, 2017

Thanks

@arv arv merged commit e6c5675 into attic-labs:master Sep 14, 2017

1 check passed

default Build finished.
Details

@wardn wardn deleted the wardn:jsremove branch Sep 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment