New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code blocks to always specify syntax, fix ordered list #3734

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
2 participants
@jesseditson
Contributor

jesseditson commented Sep 22, 2017

General cleanup to finish up the last bit of formatting on attic-labs/decent-website#13

@jesseditson jesseditson requested review from aboodman and phritz Sep 22, 2017

@phritz

phritz approved these changes Sep 22, 2017 edited

Looks good except for some of the bullets in the ul in quickstart step 6 need indentation.

@jesseditson

This comment has been minimized.

Show comment
Hide comment
@jesseditson

jesseditson Sep 22, 2017

Contributor

Intentionally outdented the code there because it seems like showdownjs doesn't support indented code blocks - I could preprocess the blocks (I currently do that but I don't like it), but my preference is to just use formatting it can handle. What do you think?

Contributor

jesseditson commented Sep 22, 2017

Intentionally outdented the code there because it seems like showdownjs doesn't support indented code blocks - I could preprocess the blocks (I currently do that but I don't like it), but my preference is to just use formatting it can handle. What do you think?

@phritz

This comment has been minimized.

Show comment
Hide comment
@phritz

phritz Sep 22, 2017

phritz commented Sep 22, 2017

@phritz

This comment has been minimized.

Show comment
Hide comment
@phritz

phritz Sep 22, 2017

phritz commented Sep 22, 2017

@jesseditson jesseditson merged commit 8be0ae7 into attic-labs:master Sep 23, 2017

1 check passed

default Build finished.
Details

@jesseditson jesseditson deleted the jesseditson:syntax_highlighting branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment