New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with marshal caching vrw #3785

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@arv
Contributor

arv commented Nov 15, 2017

We were caching the encoder function enclosing over the passed in
ValueReadWriter. This causes problems when the encoder is used again but
with another ValueReadWriter.

Instead, make the internal encoder function take a ValueReadWriter.

Fix issue with marshal caching vrw
We were caching the encoder function enclosing over the passed in
ValueReadWriter. This causes problems when the encoder is used again but
with another ValueReadWriter.

Instead, make the internal encoder function take a ValueReadWriter.

@arv arv requested review from kalman and rafael-atticlabs Nov 15, 2017

@arv

This comment has been minimized.

Show comment
Hide comment
@arv

arv Nov 15, 2017

Contributor

FYI @tobowers

Contributor

arv commented Nov 15, 2017

FYI @tobowers

@arv arv merged commit 38a9798 into attic-labs:master Nov 15, 2017

@arv arv deleted the arv:marshal-vrw branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment