Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message_checkのリファクタリング #1

Merged
merged 1 commit into from Jul 12, 2012

Conversation

@hanachin
Copy link
Contributor

commented Jul 12, 2012

Message_checkのクラス名をMessageCheckに変更して、テストケースを追加し、リファクタリングしました。

@hanachin

This comment has been minimized.

Copy link
Member Author

commented on message_check.rb in b154f69 Jul 12, 2012

originalのusernameが含まれてるかどうか調べるなら、contain_original_names?の方が、メソッド名として適切かも。

@hanachin

This comment has been minimized.

Copy link
Member Author

commented on message_check.rb in b154f69 Jul 12, 2012

ifのネストがいやだったのでcase使いました。

@hanachin

This comment has been minimized.

Copy link
Member Author

commented on ngskbot.rb in b154f69 Jul 12, 2012

クラス名は_区切りじゃなくてUpperCamelCaseが慣習的に読みやすいので変更しました。

atton added a commit that referenced this pull request Jul 12, 2012
@atton atton merged commit ef8f522 into atton:master Jul 12, 2012
@hanachin

This comment has been minimized.

Copy link
Member Author

commented on message_check.rb in b154f69 Jul 12, 2012

"@#{@bot_name}"みたいに埋め込んで使ってるところしか無かったので、最初に@つきのテキストで持ってた方が取り扱いやすそうだったので、変更しました。
あとuser_nameは実際には配列で、複数の名前を取ることがあるので、複数形のuser_namesに変更しました。

@atton

This comment has been minimized.

Copy link
Owner

commented Jul 12, 2012

マージってみましたー。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.