Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Why? Hostnames can change a lot, and therefore host filtering can be funky. Really, all we want is a unique ID per machine + do not care what it might be.
ellie
commented
Jun 14, 2023
| async fn push(&self, record: Record) -> Result<Record>; | ||
| // Push a record | ||
| async fn push(&self, record: &Record) -> Result<()> { | ||
| self.push_batch(std::iter::once(record)).await |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super basic PoC, that adds a few things
This stores a linked list of... data. Actually just anything! This data could be shell history, but for now is simple key-values. The idea here is to store it locally in a format that works much better for effective syncing. Note that we store it per host. This is intentional, as when sync works the idea is that machines will write their own local data, but read from all
This is both a cool feature that we wanted, but also a demo of the sync. Rather than mess with history sync from day 0, we can do it with something lower stakes.
This is not final. I still need to implement sync, and I still need to "build" the history records into an actual kv store. The idea of a record store is not that live queries will run on it, but that it will act as a source of truth