Add RecordIndex data structure#1059
Merged
Merged
Conversation
This allows us to compare two sets of record stores, and return a list of diffs. With these diffs, we should be able to sync the two stores
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
conradludgate
previously approved these changes
Jun 19, 2023
conradludgate
left a comment
conradludgate
left a comment
Collaborator
There was a problem hiding this comment.
I'm not 100% sure how this fits into the bigger picture just yet, but the code seems fine (double hashmaps upset me but I don't know any other solutions)
Co-authored-by: Conrad Ludgate <conradludgate@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to compare two sets of record stores, and return a list of diffs.
With these diffs, we should be able to sync the two stores
I'll probably replace the diff tuple with an actual type once the sync process is there, but I'd like to see how it needs to be used first