Skip to content

Automatically filter out secrets#1182

Merged
ellie merged 1 commit intomainfrom
ellie/no-secrets
Aug 19, 2023
Merged

Automatically filter out secrets#1182
ellie merged 1 commit intomainfrom
ellie/no-secrets

Conversation

@ellie
Copy link
Copy Markdown
Member

@ellie ellie commented Aug 19, 2023

I'd like to extend the regex list here very soon, but start off by automatically filtering out secrets. Do not store them in history!

I've included regex for:

  1. AWS key id
  2. Github pat (old and new)
  3. Slack oauth tokens (bot, user)
  4. Slack webhooks
  5. Stripe live/test keys

#806 will need rebasing

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2023 11:24am

I'd like to extend the regex list here very soon, but start off by
automatically filtering out secrets. Do not store them in history!

I've included regex for:

1. AWS key id
2. Github pat (old and new)
3. Slack oauth tokens (bot, user)
4. Slack webhooks
5. Stripe live/test keys

Will need updating after #806
@ellie ellie force-pushed the ellie/no-secrets branch from d3a7ddd to 2132d85 Compare August 19, 2023 11:24
@ellie ellie merged commit 73bd801 into main Aug 19, 2023
@ellie ellie deleted the ellie/no-secrets branch August 19, 2023 11:28
@conradludgate
Copy link
Copy Markdown
Collaborator

Maybe add a settings entry for custom exclusions?

@ellie
Copy link
Copy Markdown
Member Author

ellie commented Aug 19, 2023

Maybe add a settings entry for custom exclusions?

We already have that haha, it's history_filter

This is a set of defaults you can opt out of, regardless of your history filter settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants