add --reverse to history list

[kiran-4444]

Tried working on this issue: #1239
This is a WIP and a very minimal (and brute force) implementation I did to get a hang of the repo. Seeking feedback on this. Thanks!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
atuin-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 29, 2023 11:00am

[deicon]

First off, please change this to be a Draft PR.

[deicon]

Documentation is missing for the new parameter
https://github.com/atuinsh/atuin/blob/main/docs/docs/commands/list.md

[deicon]

One last question here would be, if it would be better to get the result sorted from the DB instead of reverse the vec afterwards. I would argue, in this case here, reverse should be fine, but obviously not the most optimal way of doing things.

[deicon]

I asked for Draft, as it was titled WIP. But it looks like its more than WIP.

[kiran-4444]

One last question here would be, if it would be better to get the result sorted from the DB instead of reverse the vec afterwards. I would argue, in this case here, reverse should be fine, but obviously not the most optimal way of doing things.

I'm intimidated to change that Database's list function, I'll now try to do this at DB level.

[deicon]

One last question here would be, if it would be better to get the result sorted from the DB instead of reverse the vec afterwards. I would argue, in this case here, reverse should be fine, but obviously not the most optimal way of doing things.

I'm intimidated to change that Database's list function, I'll now try to do this at DB level.

@ellie / @conradludgate probably have an opinion here.

[conradludgate]

One last question here would be, if it would be better to get the result sorted from the DB instead of reverse the vec afterwards. I would argue, in this case here, reverse should be fine, but obviously not the most optimal way of doing things.

We can avoid any reversing in sql or in code.

In print_list we iterate over the history items already in reverse.

atuin/atuin/src/command/client/history.rs

Line 116 in fbed286

for h in h.iter().rev() {

We can choose whether we want to iterate over h.iter() or h.iter().rev() depending.

Let me know if you want some more help navigating the rust side of implementing this

[kiran-4444]

Let me know if you want some more help navigating the rust side of implementing this

Yeah, I need some help with that.

[deicon]

@kiran-4444 you might want to consoder to remove the WIP and make it an active PR

[deicon]

If no longer wip just mark as active :)

[conradludgate]

Thanks :)

[kiran-4444]

Are there any issues I can work on? Went through issues list... but I just some help in selecting one.