Re-enable linux/arm64 platform in CI docker build#1276
Merged
Conversation
This was previously enabled in atuinsh#616 and then reverted in atuinsh#730.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ellie
approved these changes
Oct 2, 2023
ellie
left a comment
ellie
left a comment
Member
There was a problem hiding this comment.
I'm happy to give this a try, but until we can run it on native ARM it probably won't be great. Historically it has been pretty unreliable and slow
Member
|
If it's slow and unreliable I will likely disable it until github offer ARM or we just run out own. I know that's not ideal, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously enabled in #616 and then reverted in #730.
The
ghcr.io/atuinsh/atuin:maindocker image doesn't provide an arm variant, making it harder to self-host on arm using docker.