Skip to content

Add bash support to enter_accept#1316

Merged
ellie merged 1 commit into
mainfrom
ellie/accept-bash
Oct 21, 2023
Merged

Add bash support to enter_accept#1316
ellie merged 1 commit into
mainfrom
ellie/accept-bash

Conversation

@ellie
Copy link
Copy Markdown
Member

@ellie ellie commented Oct 20, 2023

It's a little less smooth than ZSH or Fish. The actual text to execute isn't entered before being eval-d like on the other shells, and if I try and set it then the command is inserted after it is evaluated. ew.

Maybe explore BLE or similar in the future

It's a little less smooth than ZSH or Fish. The actual text to execute
isn't entered, and if I try and set it then the command is inserted
_after_ it is evaluated. ew.

Maybe explore BLE or similar in the future
@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview Oct 20, 2023 7:55am

@ellie ellie requested a review from conradludgate October 21, 2023 11:31
@ellie ellie enabled auto-merge (squash) October 21, 2023 11:31
Copy link
Copy Markdown
Collaborator

@conradludgate conradludgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh, fine

@ellie ellie merged commit 08a01e0 into main Oct 21, 2023
@ellie ellie deleted the ellie/accept-bash branch October 21, 2023 11:34
@ellie
Copy link
Copy Markdown
Member Author

ellie commented Oct 21, 2023

Meh, fine

Honestly don't think we will get bash to ever feel as nice without layers of hacks 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants