Skip to content

allow binding server to hostname#1318

Merged
conradludgate merged 1 commit intomainfrom
bind-to-hostname
Oct 21, 2023
Merged

allow binding server to hostname#1318
conradludgate merged 1 commit intomainfrom
bind-to-hostname

Conversation

@conradludgate
Copy link
Copy Markdown
Collaborator

I was sent a message with:

host = "mithril": Error: invalid IP address syntax why's it called host if it wants an IP

This makes the host field support more than just IPs, doing a getaddrinfo lookup if necessary

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2023 10:31am

@conradludgate conradludgate enabled auto-merge (squash) October 21, 2023 10:48
@ellie
Copy link
Copy Markdown
Member

ellie commented Oct 21, 2023

why's it called host if it wants an IP

Bind hosts do generally mean IP 😅

@conradludgate conradludgate merged commit d202afe into main Oct 21, 2023
@conradludgate conradludgate deleted the bind-to-hostname branch October 21, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants