Skip to content

Conversation

@ellie
Copy link
Member

@ellie ellie commented Jan 8, 2024

The columns referred to in this PR, were for some reason created with defaults. When created years ago, they were bigserial not bigint.

The defaults were never actually used, as verified by

  1. Checking the value of the sequences on the database
  2. Checking the code

So we're safe to clean them up.

@vercel
Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 1:20pm

The columns referred to in this PR, were for some reason created with
defaults. When created years ago, they were `bigserial` not `bigint`.

The defaults were never actually used, as verified by

1. Checking the value of the sequences on the database
2. Checking the code

So we're safe to clean them up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants