refactor(bash): refactor and localize HISTORY => __atuin_output
#1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akinomyoga
force-pushed
the
bash-HISTORY
branch
from
d919c50 to
6366409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relatively trivial. I do not see the global variable
HISTORYset by__atuin_historybeing documented. Also, the variable names are different for different shells (e.g.outputin zsh, andATUIN_Hin fish), so this doesn't seem to be a part of the public interface of Atuin's integration. I'd suggest localizing those variables. Note thatATUIN_Hin fish seems to be already local. I'm not sure how this is processed for the Nu shell integration, but I guess it would be processed without creating a variable.I also localize
outputset by the Zsh integration. Even if we expose it on purpose, the variable name choice doesn't seem nice to avoid conflicts with the users' variables.