refactor(search): refactor vim mode #1559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YummyOreo
reviewed
Jan 14, 2024
YummyOreo
approved these changes
Jan 14, 2024
ellie
previously approved these changes
Jan 14, 2024
This patch reduces the code duplication.
Contributor
Author
|
fixed format. |
In the current implementation, the combination of settings.invert and settings.vim is not considered. This patch implements it.
In this patch, we apply the rules for vim-modes only on `j` and `k` without the Control modifier. With the current set of keybindings, the current implementation does not cause a problem because `j` and `k` behave the same as `C-j` and `C-j` within the vim-normal mode. However, this is just accidental and can be broken by future changes. To make these keybindings orthogonal, it is better to explicitly check the Control modifier.
Contributor
Author
|
Sorry, I fixed the wrong part. I again fixed it. Now the checks passed. |
ellie
approved these changes
Jan 14, 2024
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the change to the configuration interface of the newly introduced vim mode, I'd like to first refactor/fix the behaviors of corner cases. I left details in the commit messages.
@YummyOreo @ellie Could you check these?