fix(bash): strip control chars generated by \[\] in PS1 with bash-preexec
#1620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1617
This contains an extra commit dc2afa7, which counts the newlines in the prompt result using Bash's built-in features. The previous implementations used the external command
wcwith the command substitution, which involves 3 forks and 1 exec so is slow. We can count newlines by first removing all the characters except for the newlines and then counting the number of remaining characters.