Skip to content

Conversation

@ellie
Copy link
Member

@ellie ellie commented Jan 30, 2024

Now that local history is stored encrypted, new_key should not overwrite an existing one. This may be frustrating, but will remove the risk of Atuin generating a new key and the user losing their old one.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Now that local history is stored encrypted, new_key should not overwrite
an existing one. This may be frustrating, but will remove the risk of
Atuin generating a new key and the user losing their old one.
@ellie
Copy link
Member Author

ellie commented Jan 30, 2024

if we wish to generate a new key, the options are

  1. Manually delete it, re run
  2. Delete it in code, very explicitly. Rather than overwrite.

@ellie ellie merged commit 335f222 into main Jan 30, 2024
@ellie ellie deleted the ellie/no-overwrite-key branch January 30, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant