fix(ui): don't preserve for empty space#1712
Merged
ellie merged 1 commit intoatuinsh:mainfrom Feb 13, 2024
Merged
Conversation
For the following situation:
$ atuin search -i --inline-height 15
[ HOST ] query
> 1m 19d ago item 1
1 0s 1mo ago item 2
2 0s 1mo ago item 3
3 0s 1mo ago item 4
4 0s 1mo ago item 5
5 0s 1mo ago item 6
Atuin v17.2.1 [...]
Scrolling item 6 results:
[ HOST ] query
0s 1mo ago item 3
0s 1mo ago item 4
0s 1mo ago item 5
> 0s 1mo ago item 6
Atuin v17.2.1 [...]
With this patch it becomes:
[ HOST ] query
1m 19d ago item 1
0s 1mo ago item 2
0s 1mo ago item 3
0s 1mo ago item 4
0s 1mo ago item 5
> 0s 1mo ago item 6
Atuin v17.2.1 [...]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the following situation:
Scrolling to item 6 results:
With this patch it becomes:
Checks