add 'ignored_commands' option to stats#1722
Merged
Merged
Conversation
ellie
reviewed
Feb 14, 2024
6db0f58 to
1b84e40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #1714.
I add a
ignored_commandsoption tostatsso that common commands that you don't want showing up in stats can be skipped.compute_stats-- I think in the long run the way to test this is by splitting outcompute_statsfrom the function that prints the results, but I thought that might be too much for this PR. Happy to take a stab at this if you disagree.Output on my machine, using
ignored_commands = ["cd", "vi", "ls"]:(before)
(after)
Checks