fix(bash): rework #1509 to recover from the preexec failure#1729
Merged
Conversation
akinomyoga
force-pushed
the
workaround-keybinding-preexec
branch
from
e92df4c to
abe7514
Compare
In GitHub atuinsh#1509, we blocked the unintended preexec event caused by the keybinding of Atuin. However, with that fix, the preexec event for the intended user command is still missing. In this patch, we try to manually run the preexec hook when we detected the unintended preexec (which means the missing intended preexec). References: atuinsh#1509 https://forum.atuin.sh/t/atuin-bash-and-ble-sh/175 atuinsh#1003 (comment) atuinsh#1727 atuinsh#1728
akinomyoga
force-pushed
the
workaround-keybinding-preexec
branch
from
abe7514 to
cb11af2
Compare
ellie
reviewed
Feb 17, 2024
ellie
left a comment
ellie
left a comment
Member
There was a problem hiding this comment.
This works great! I tried a few variations that did not work previously and this seems to have resolved the issue. Thank you 🙏
ellie
approved these changes
Feb 17, 2024
ellie
pushed a commit
that referenced
this pull request
Feb 26, 2024
In GitHub #1509, we blocked the unintended preexec event caused by the keybinding of Atuin. However, with that fix, the preexec event for the intended user command is still missing. In this patch, we try to manually run the preexec hook when we detected the unintended preexec (which means the missing intended preexec). References: #1509 https://forum.atuin.sh/t/atuin-bash-and-ble-sh/175 #1003 (comment) #1727 #1728
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanations are in the commit message. I've quickly tested it locally and confirmed that the user commands are at least not missing, but I think @ellie can also test it locally to carefully see the behavior.
Refs. #1003, #1509, #1727, #1728, Forum 175
Checks