feat(client): add config option keys.scroll_exits #1744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the config option is set the `false`, using the up/down key won't exit the TUI when scrolled past the first/last entry. Example: ``` [keys] scroll_exits = false ``` The default is `true`, which is the current behavior.
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: https://forum.atuin.sh/t/add-option-to-stop-down-arrow-exiting-search/94/9 |
akinomyoga
reviewed
Feb 21, 2024
Contributor
akinomyoga
left a comment
akinomyoga
left a comment
There was a problem hiding this comment.
The config scroll_exists should also be mentioned in atuin-client/config.toml.
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
ellie
approved these changes
Feb 21, 2024
Member
ellie
left a comment
ellie
left a comment
There was a problem hiding this comment.
LGTM, thank you!
Could we also get an update to the docs please? https://github.com/atuinsh/docs
Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config option is set the
false, using the up/down key won't exit the TUI when scrolled past the first/last entry.Example:
The default is
true, which is the current behavior./ref https://forum.atuin.sh/t/add-option-to-stop-down-arrow-exiting-search/94
fixes #922
Checks