feat: support regex with r/.../ syntax#1745
Merged
Merged
Conversation
Member
|
Looks good overall, but would it also be possible to get some tests (given the complexity of this) please? You should be able to start with copying one of the tests at the bottom of the same file Thanks! |
|
Hi there, i just found out i can search via regex, which is great of course. I couldn't find it. If not, should it be added? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks
As discussed in https://forum.atuin.sh/t/a-regex-search-mode/169/16.
I hope there are no missed edge cases.