Clarify operation result for working with aliases#1748
Merged
ellie merged 1 commit intoatuinsh:mainfrom Feb 21, 2024
Merged
Conversation
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to clarify the info messages when working with aliases. No functional changes were made.
The delete message mentions which alias with which value was deleted so that the user can confirm that this is indeed the alias they wanted to remove. If not, they can reset it again. In case of an error, the error message format of
rmis followed:problem: reason(rm: cannot remove 'file': No such file or directory).The set alias message clearly separates the beginning and end of alias
name=valuefrom the normal text. Otherwise, one needs to parse thename=value with name=value2wherewithblends in with the end of thevalue.If the changes are not to your liking, feel free to modify or close the PR.
Checks