Add config setting for showing tabs#1755
Merged
ellie merged 2 commits intoatuinsh:mainfrom Mar 1, 2024
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
Oh, I actually wanted the tabs themselves to be hidden. |
This comment was marked as spam.
This comment was marked as spam.
ellie
approved these changes
Mar 1, 2024
Member
ellie
left a comment
ellie
left a comment
There was a problem hiding this comment.
I get @tessus' point about show_tabs being a little ambiguous, but I'm happy with this as-is due to how it matches nicely with show_help.
If you could also make a PR to the docs, that would be great! https://github.com/atuinsh/docs
Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!
We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: https://forum.atuin.sh/t/feedback-playing-with-inspector/218/2 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #1754
Yet to do local testing, but this is what I had in mind.
Checks