fix(nushell): readd up-arrow keybinding, now with menu handling#1770
Merged
Conversation
Contributor
Author
|
Since it's easy to test out, we should probably wait a little for feedback confirming that this fixes the issue 🙂 |
Contributor
|
Awesome! I've confirmed that this snippet works as well. This probably needs a small matching PR in https://github.com/atuinsh/docs to remove https://github.com/atuinsh/docs/blob/a814efba030b985942c09c215122f655f36272c0/src/content/docs/configuration/key-binding.mdx#L52 I'll also ping nushell/nushell#10414 so there is a link to the solution :) |
Contributor
Author
|
I see - added the docs PR :) |
ellie
pushed a commit
to atuinsh/docs
that referenced
this pull request
Feb 28, 2024
This updates the docs in case atuinsh/atuin#1770 lands, which fixes the referenced issue atuinsh/atuin#1025 Since this hasn't happened yet I created this as a draft - feel free to un-draft it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1025
This seems to work, see the nushell docs for
until, and how it can account for the menu handling: https://www.nushell.sh/book/line_editor.html#until-typeChecks