Merged
Conversation
ellie
reviewed
Mar 1, 2024
added 2 commits
April 3, 2024 02:01
ellie
approved these changes
Apr 18, 2024
Member
ellie
left a comment
ellie
left a comment
There was a problem hiding this comment.
Looks good, thank you! I appreciate the work on the tests 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a new config option
show_preview_auto = true|falsewithtruebeing the default.I wanted to originally replace the current boolean option
show_previewwith an option that takes also the valueauto. But this would've been a breaking change and should be done when the config/settings are updated to the new format. I am more than happy to create another PR then./ref Show preview only if command longer than terminal width
Checks