Nushell: check if command history is disabled

[IanManske]

Somewhat recently in Nushell, we added a CLI option to disable command history. This is very similar to fish's private mode. Like in #577, this PR skips atuin history start if history is disabled.

Checks

• I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
• I have checked that there are no existing pull requests for the same thing

[remmycat]

I'm wondering if it makes sense to take nushell's setting here?

I think the way things are today, the two history implementations have no connection apart from the option to import nushell's history into atuin.

Personally I would like to see a kind of "native" integration of atuin into nushell, but until then I would consider disabling nushell's history in my config because atuin is handling it for me already and I don't need to have it recorded twice 🤔

(But I can see the argument how it can become a privacy issue if a user believes they did disable the history everywhere from nushell's config)

Edit:

I hadn't considered that as a CLI flag, and not a global nushell setting, it is not behaving in a way where I would use this for just disabling nu's history altogether. So I think this makes a lot of sense to honor in atuin too.

[IanManske]

Good point, if it was a config option, then it would probably make sense to disregard it. But yeah, it's a CLI option like you mentioned, so I think it makes sense to handle it like fish's private mode given their similarity.

[ellie]

Thanks for this!

Makes sense to have this as a "private mode". I do agree with the discussion though - if Nu introduces a global history off switch, ignoring it would be the best approach

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!