chore(ci): add cross-compile job for illumos - #1830
Merged
Merged
Conversation
I also tried getting FreeBSD to work, but didn't get too far sadly. I don't have the time to debug this so I just put in a comment for now. (With my changes, Atuin works great on FreeBSD as well.)
sunshowers
commented
Mar 6, 2024
Comment on lines
+57
to
+82
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install cross | ||
| uses: taiki-e/install-action@v1 | ||
| with: | ||
| tool: cross | ||
|
|
||
| - uses: actions/cache@v3 | ||
| with: | ||
| path: | | ||
| ~/.cargo/registry | ||
| ~/.cargo/git | ||
| target | ||
| key: ${{ matrix.target }}-cross-compile-${{ hashFiles('**/Cargo.lock') }} | ||
|
|
||
| - name: Run cross build common | ||
| run: cross build -p atuin-common --locked --target ${{ matrix.target }} | ||
|
|
||
| - name: Run cross build client | ||
| run: cross build -p atuin-client --locked --target ${{ matrix.target }} | ||
|
|
||
| - name: Run cross build server | ||
| run: cross build -p atuin-server --locked --target ${{ matrix.target }} | ||
|
|
||
| - name: Run cross build main | ||
| run: cross build --all --locked --target ${{ matrix.target }} |
Contributor
Author
There was a problem hiding this comment.
I noticed that the indentation for this is slightly off from what YAML (or at least Prettier) recommends:
steps:
- uses: actions/checkout@v3
- name: Install cross
# ...I changed it to match the rest of the file, but it may be worth fixing this at some point. (Again, happy to send a PR for this.)
Member
There was a problem hiding this comment.
Again, happy to send a PR for this.
If you have the time, that would be very much appreciated! 🙏
2 tasks
ellie
approved these changes
Mar 6, 2024
ellie
left a comment
ellie
left a comment
Member
There was a problem hiding this comment.
Nice one, thank you!
I actually expected it to be a bit slower, pretty impressed that it only took ~5 mins to build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #1825.
I also tried getting FreeBSD to work, but didn't get too far sadly. I don't have the time to debug this so I just put in a comment for now. (With my changes, Atuin works great on FreeBSD as well.)
Checks