Skip to content

feat: prevents stderr from going to the screen when syncing nushell#1933

Merged
ellie merged 1 commit intoatuinsh:mainfrom
YummyOreo:nushell-script
Apr 9, 2024
Merged

feat: prevents stderr from going to the screen when syncing nushell#1933
ellie merged 1 commit intoatuinsh:mainfrom
YummyOreo:nushell-script

Conversation

@YummyOreo
Copy link
Copy Markdown
Contributor

I have no idea why this works, but it does! The problem was that when atuin was syncing after a command, it would print the progress bar, this fixes it!

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Copy Markdown
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! (https://www.nushell.sh/commands/docs/complete.html#complete-for-system for anyone else)

Though I think complete is a bit of a weird name

Thanks for fixing :)

@ellie ellie merged commit c384179 into atuinsh:main Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants