fix: use spawn_blocking for file access during async context#1936
Merged
Conversation
Member
|
is this ready for review? (still a draft) |
Collaborator
Author
|
I was planning to shuffle around when the db queries happen too, relative to rendering, but I can do that separately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
update checking runs asynchronously to allow DB and UI rendering to occur concurrently with the otherwise superficial update check system.
The file accesses that take place during this check run synchronously on the main thread and can block the runtime from running the render routine. I wouldn't expect the file accesses to take long but filesystems can be weird I guess?
(extra context, tokio::fs::File also does spawn_blocking, so I would stick with fs-err here for the better error messages and not use tokio::fs)
Checks