docs(bash-preexec): describe the limitation of missing commands#1937
docs(bash-preexec): describe the limitation of missing commands#1937ellie merged 1 commit intoatuinsh:mainfrom
Conversation
ellie
left a comment
There was a problem hiding this comment.
lgtm
may also be worth adding something to atuin doctor when it detects someone using bash-preexec
|
Thanks!
Yeah. Maybe a troubleshooting section can be added in README. |
I'd rather add it to the docs and the doctor. My experience so far has been that people tend to ignore dense information - the docs has search, and if someone opens an issue without doing their own search, the doctor should catch that too |
|
Ah, OK. I misread your previous comment! (I misunderstood you would be adding something related to |
|
BTW, I have a commit akinomyoga@0598e4a for |
Seems reasonable to me! |
|
Thank you! Then, I'll later submit a PR after some refinements. |
I noticed that the problem of missing commands with
bash-preexecis not mentioned in README. This PR adds a mention.Also, the quick instruction at the beginning of README doesn't mention the possible minor problems with Bash integration, so I added a link to the later Bash section, which describes the problems in more detail.
As another change, I made those "notes" more outstanding using the GFM blockquote so that users do not miss them. There are still reports by users who missed those notes (like #1921).
Checks