Skip to content

fix(dotfiles): unquote aliases before quoting#1976

Merged
ellie merged 2 commits into
mainfrom
ellie/ffs-fish-why
Apr 23, 2024
Merged

fix(dotfiles): unquote aliases before quoting#1976
ellie merged 2 commits into
mainfrom
ellie/ffs-fish-why

Conversation

@ellie
Copy link
Copy Markdown
Member

@ellie ellie commented Apr 23, 2024

We want to quote all aliases when setting config. Aliases in the store may be quoted, but may also be unquoted.

First normalise to unquoted, then quote.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@ellie ellie merged commit bf88b42 into main Apr 23, 2024
@ellie ellie deleted the ellie/ffs-fish-why branch April 23, 2024 13:45
@tessus

This comment was marked as spam.

@ellie
Copy link
Copy Markdown
Member Author

ellie commented Apr 23, 2024

They all work without issue!

At least setting from the CLI. I'll double check importing.

@ellie
Copy link
Copy Markdown
Member Author

ellie commented Apr 23, 2024

Yep all good for imports too

@tessus

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants