Skip to content

feat(dotfiles): support syncing shell/env vars#1977

Merged
ellie merged 1 commit intomainfrom
ellie/dotfiles-vars
Apr 25, 2024
Merged

feat(dotfiles): support syncing shell/env vars#1977
ellie merged 1 commit intomainfrom
ellie/dotfiles-vars

Conversation

@ellie
Copy link
Member

@ellie ellie commented Apr 24, 2024

There's a bunch of duplication here!

I'd also like to support syncing shell "snippets", aka just bits of shell config that don't fit into the structure here. Potentially special handling for PATH too.

Rather than come up with some abstraction in the beginning, which inevitably will not fit future uses, I'm duplicating code for now.

Once all the functionality is there, I can tidy things up and sort a proper abstraction out.

Something in atuin-client for map/list style synced structures would probably work best.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

There's a bunch of duplication here!

I'd also like to support syncing shell "snippets", aka just bits of
shell config that don't fit into the structure here. Potentially special
handling for PATH too.

Rather than come up with some abstraction in the beginning, which
inevitably will not fit future uses, I'm duplicating code _for now_.

Once all the functionality is there, I can tidy things up and sort a
proper abstraction out.

Something in atuin-client for map/list style synced structures would
probably work best.
@ellie ellie force-pushed the ellie/dotfiles-vars branch from c50a933 to aa1de6d Compare April 24, 2024 15:10
@ellie ellie merged commit d020c81 into main Apr 25, 2024
@ellie ellie deleted the ellie/dotfiles-vars branch April 25, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant