Skip to content

feat(daemon): add support for daemon on windows#2014

Merged
ellie merged 14 commits intoatuinsh:mainfrom
YummyOreo:windows-daemon
May 13, 2024
Merged

feat(daemon): add support for daemon on windows#2014
ellie merged 14 commits intoatuinsh:mainfrom
YummyOreo:windows-daemon

Conversation

@YummyOreo
Copy link
Copy Markdown
Contributor

@YummyOreo YummyOreo commented May 11, 2024

Add support for the daemon on windows using tcp.

fixes #2011

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Copy Markdown
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but nothing major! Thanks for the work 🚀

Copy link
Copy Markdown
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you! :shipit:

@ellie ellie merged commit ce67e52 into atuinsh:main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: atuin does not compile on windows since daemon was added

2 participants