perf: only open the database for commands if strictly required - #2043
Merged
Conversation
1 task
The client commands would open sqlite, even if not 100% required Remove this for 1. history start/end 2. shell init Init seems to be around 2ms faster on my system, with this change.
ellie
force-pushed
the
ellie/daemon-no-open-sqlite
branch
from
May 25, 2024 09:20
c954da1 to
437040f
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client commands would open sqlite, even if not 100% required
Remove this for
Init seems to be around 2ms faster on my system, with this change.
Checks