Skip to content

fix(bash): fix a workaround for bash-4.2 keybindings#2060

Merged
ellie merged 1 commit into
atuinsh:mainfrom
akinomyoga:bash42-bind
May 30, 2024
Merged

fix(bash): fix a workaround for bash-4.2 keybindings#2060
ellie merged 1 commit into
atuinsh:mainfrom
akinomyoga:bash42-bind

Conversation

@akinomyoga

Copy link
Copy Markdown
Contributor

See the commit message. This fixes a problem reported at https://forum.atuin.sh/t/up-arrow-error-commands-not-saved/339

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

The workaround for Bash <= 4.2 in the vi-editing mode was broken.  One
should not use `bind -x' for the string macro keybindings.

https://forum.atuin.sh/t/up-arrow-error-commands-not-saved/339/1

@ellie ellie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellie ellie merged commit f6918d9 into atuinsh:main May 30, 2024
@akinomyoga akinomyoga deleted the bash42-bind branch May 30, 2024 21:25
@atuin-bot

Copy link
Copy Markdown

This pull request has been mentioned on Atuin Community. There might be relevant details there:

https://forum.atuin.sh/t/up-arrow-error-commands-not-saved/339/5

@Thorsmercy Thorsmercy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7open

@akinomyoga akinomyoga changed the title fix(bash): fix a workaround for bash-5.2 keybindings fix(bash): fix a workaround for bash-4.2 keybindings Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants