feat(doctor): report sqlite version#2075
Merged
ellie merged 1 commit intoatuinsh:mainfrom Jun 3, 2024
xvello:xvello/doctor-sqlite
Merged
feat(doctor): report sqlite version#2075ellie merged 1 commit intoatuinsh:mainfrom xvello:xvello/doctor-sqlite
ellie merged 1 commit intoatuinsh:mainfrom
xvello:xvello/doctor-sqlite
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the sqlite version to detect unsupported versions possibly brought in by third-party patching.
We could also grab the
libsqlite3_sys::SQLITE_VERSIONconstant, but it requires listing this transitive dependencies in the deps, as sqlx_sqlite does not re-export this constant. Opening a sqlite connection also allows querying the build flags, which we might want to log too.Checks