fix(client): better error reporting on login/registration#2076
Merged
Conversation
Contributor
Author
|
Yes, my weekend has been very rainy, thank you very much ☔ |
ellie
approved these changes
Jun 3, 2024
ellie
left a comment
Member
There was a problem hiding this comment.
lgtm, thank you!
Tangentially related, should handle_resp_error directly call ensure_version now, to ensure a consistent behaviour?
I imagine this would make more sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2030 - unless you downgraded
api.atuin.shby mistake, this is misleading error reporting on non-200 responses:handle_resp_errorhelper on the registration and login code paths for consistency. Tune its strings to be a bit more generic, feel free to rewordensure_versionif the header is not preset. Since we bumped the major version, the fallback is not needed + the header has been present for 6 monthsTangentially related, should
handle_resp_errordirectly callensure_versionnow, to ensure a consistent behaviour?Checks