Skip to content

Fix 2081: Replace serde_yaml::to_string with serde_json::to_string_yaml#2087

Merged
ellie merged 1 commit intoatuinsh:mainfrom
hesampakdaman:main
Jun 4, 2024
Merged

Fix 2081: Replace serde_yaml::to_string with serde_json::to_string_yaml#2087
ellie merged 1 commit intoatuinsh:mainfrom
hesampakdaman:main

Conversation

@hesampakdaman
Copy link
Contributor

Closes #2081.

The output will look a bit uglier, but it does the job. Here's my machine

{
  "atuin": {
    "version": "18.2.0",
    "sync": null,
    "sqlite_version": "3.44.0"
  },
  "shell": {
    "name": "bash",
    "default": "bash",
    "plugins": [],
    "preexec": null
  },
  "system": {
    "os": "Ubuntu",
    "arch": "x86_64",
    "version": "23.10",
    "disks": [
      {
        "name": "/dev/sda2",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/sdb1",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/sda2",
        "filesystem": "ext4"
      }
    ]
  }
}

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 9943c53 into atuinsh:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

serde_yaml is deprecated

2 participants