New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testsuite fails on Railo 4.0.3 #121

Closed
marbetschar opened this Issue Jan 15, 2013 · 7 comments

Comments

Projects
None yet
3 participants
@marbetschar

marbetschar commented Jan 15, 2013

The followings tests of the testSuite are failing on Railo 4.0.3

returns_error_when_default_mime_not_implemented
returns_error_when_requested_mime_not_supported
returns_error_when_requested_mime_not_supported
put_body_is_mime_content
put_body_is_url_encoded_params
basic_auth_credentials_found
can_upload_a_file

On our end we have seen a bug using multipart/form-data to upload a file via CFHTTP by using Railo in the past. This issue isn't solved and may be related to the failing "can_upload_a_file". I've no idea why this file upload is not working on Railo but this bug is there since Railo 3.3.

Maybe you could see why this is not working, because I wasn't able to break down the error and we need this functionality in an actual project :(

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Jan 21, 2013

Owner

I don't have a great Railo testing environment right now. I had originally been using the Jetty version, but Jetty doesn't support PUT/DELETE verbs, and I don't have time to futz around with Tomcat right now...

Owner

atuttle commented Jan 21, 2013

I don't have a great Railo testing environment right now. I had originally been using the Jetty version, but Jetty doesn't support PUT/DELETE verbs, and I don't have time to futz around with Tomcat right now...

@jbvanzuylen

This comment has been minimized.

Show comment
Hide comment
@jbvanzuylen

jbvanzuylen Jan 22, 2013

Contributor

I've been working with Adam about the file upload using Railo (#89). It is working fine at our end but I must admit that we are using an old version of Taffy (1.0 with the upload fix on Railo 3.3).

I tried to update Taffy today but got an issue because I'm on Windows (#123). But once this is fixed, I'm prepared to make the test work with Railo.

Contributor

jbvanzuylen commented Jan 22, 2013

I've been working with Adam about the file upload using Railo (#89). It is working fine at our end but I must admit that we are using an old version of Taffy (1.0 with the upload fix on Railo 3.3).

I tried to update Taffy today but got an issue because I'm on Windows (#123). But once this is fixed, I'm prepared to make the test work with Railo.

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle
Owner

atuttle commented Mar 26, 2013

@jbvanzuylen /poke

@jbvanzuylen

This comment has been minimized.

Show comment
Hide comment
@jbvanzuylen

jbvanzuylen Aug 28, 2013

Contributor

@atuttle I'm still out there, was working on another projects

I've setup an environment with Railo 4 (4.0.4.001 on Tomcat) and checked the failing tests. Here is my feedback:


returns_error_when_default_mime_not_implemented
returns_error_when_requested_mime_not_supported

With the default setup, the custom status text is replaced by the standard status messages (OK, Not Found, ...).
To enable custom status messages, you need to add the line

org.apache.coyote.USE_CUSTOM_STATUS_MSG_IN_HEADER=true

to the file catalina.properties in the configuration directory of Tomcat

That said, I'm not big fan of using the status text to indicate an error to the client. I think it better to put the error message in the body of the response like it is done in the onError method.


put_body_is_mime_content
put_body_is_url_encoded_params

They are failing because Railo is populating the form scope also on PUT requests, which ACF doesn't do. So you also get the fieldnames variable in the response. I fixed this on my side by changing the way the response is checked in the tests.


basic_auth_credentials_found

Works fine.


can_upload_a_file

I fixed the test case on my side. The URL to call Taffy was not correctly generated and led to a 404 error.

Contributor

jbvanzuylen commented Aug 28, 2013

@atuttle I'm still out there, was working on another projects

I've setup an environment with Railo 4 (4.0.4.001 on Tomcat) and checked the failing tests. Here is my feedback:


returns_error_when_default_mime_not_implemented
returns_error_when_requested_mime_not_supported

With the default setup, the custom status text is replaced by the standard status messages (OK, Not Found, ...).
To enable custom status messages, you need to add the line

org.apache.coyote.USE_CUSTOM_STATUS_MSG_IN_HEADER=true

to the file catalina.properties in the configuration directory of Tomcat

That said, I'm not big fan of using the status text to indicate an error to the client. I think it better to put the error message in the body of the response like it is done in the onError method.


put_body_is_mime_content
put_body_is_url_encoded_params

They are failing because Railo is populating the form scope also on PUT requests, which ACF doesn't do. So you also get the fieldnames variable in the response. I fixed this on my side by changing the way the response is checked in the tests.


basic_auth_credentials_found

Works fine.


can_upload_a_file

I fixed the test case on my side. The URL to call Taffy was not correctly generated and led to a 404 error.

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Aug 28, 2013

Owner

Awesome, thanks for the feedback. I'll come back and revisit this soon.

Owner

atuttle commented Aug 28, 2013

Awesome, thanks for the feedback. I'll come back and revisit this soon.

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Sep 6, 2013

Owner
  1. Status Text changes not allowed: I'm updating the documentation to reflect this. Thanks for doing the leg work!
  2. The form-scope bug is reportedly fixed in Railo 4.1.1.002 and 4.2.
  3. basic auth (not applicable)
  4. File uploads: @jbvanzuylen can you share your modification to the test? I'd like to fix it in the repo if necessary...
Owner

atuttle commented Sep 6, 2013

  1. Status Text changes not allowed: I'm updating the documentation to reflect this. Thanks for doing the leg work!
  2. The form-scope bug is reportedly fixed in Railo 4.1.1.002 and 4.2.
  3. basic auth (not applicable)
  4. File uploads: @jbvanzuylen can you share your modification to the test? I'd like to fix it in the repo if necessary...

atuttle added a commit that referenced this issue Sep 7, 2013

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Sep 20, 2013

Owner

I think this has been completely addressed, now. Closing!

Owner

atuttle commented Sep 20, 2013

I think this has been completely addressed, now. Closing!

@atuttle atuttle closed this Sep 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment