Wrong string encoding used for getting Basic Auth details #301

Closed
atuttle opened this Issue Oct 29, 2015 · 2 comments

Projects

None yet

1 participant

@atuttle
Owner
atuttle commented Oct 29, 2015

https://twitter.com/Maertsch/status/659738017163304960

BASIC auth is ISO encoded Base64, and toString() decodes it with UTF-8. This should be changed.

@atuttle atuttle added this to the Taffy 3.1 milestone Oct 29, 2015
@evagoras evagoras added a commit to evagoras/Taffy that referenced this issue Oct 29, 2015
@evagoras evagoras atuttle#301
BASIC auth is ISO encoded Base64, and toString() decodes it with UTF-8. Changed to use "iso-8859-1"
c62b7ef
@evagoras evagoras added a commit to evagoras/Taffy that referenced this issue Oct 29, 2015
@evagoras evagoras atuttle#301
Changed it to encode to "iso-8859-1"
f49b419
@atuttle atuttle closed this Oct 29, 2015
@atuttle
Owner
atuttle commented Oct 29, 2015

Re-opening so that I remember to add this bug+fix to the release notes.

@atuttle atuttle reopened this Oct 29, 2015
@atuttle atuttle closed this Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment