New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong string encoding used for getting Basic Auth details #301

Closed
atuttle opened this Issue Oct 29, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@atuttle
Owner

atuttle commented Oct 29, 2015

https://twitter.com/Maertsch/status/659738017163304960

BASIC auth is ISO encoded Base64, and toString() decodes it with UTF-8. This should be changed.

@atuttle atuttle added this to the Taffy 3.1 milestone Oct 29, 2015

evagoras added a commit to evagoras/Taffy that referenced this issue Oct 29, 2015

atuttle#301
BASIC auth is ISO encoded Base64, and toString() decodes it with UTF-8. Changed to use "iso-8859-1"

evagoras added a commit to evagoras/Taffy that referenced this issue Oct 29, 2015

atuttle#301
Changed it to encode to "iso-8859-1"

atuttle added a commit that referenced this issue Oct 29, 2015

@atuttle

This comment has been minimized.

Show comment
Hide comment
Owner

atuttle commented Oct 29, 2015

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Oct 29, 2015

Owner

Re-opening so that I remember to add this bug+fix to the release notes.

Owner

atuttle commented Oct 29, 2015

Re-opening so that I remember to add this bug+fix to the release notes.

@atuttle atuttle reopened this Oct 29, 2015

@atuttle atuttle closed this Mar 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment