Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong string encoding used for getting Basic Auth details #301

Closed
atuttle opened this issue Oct 29, 2015 · 2 comments
Closed

Wrong string encoding used for getting Basic Auth details #301

atuttle opened this issue Oct 29, 2015 · 2 comments

Comments

@atuttle
Copy link
Owner

@atuttle atuttle commented Oct 29, 2015

https://twitter.com/Maertsch/status/659738017163304960

BASIC auth is ISO encoded Base64, and toString() decodes it with UTF-8. This should be changed.

@atuttle
Copy link
Owner Author

@atuttle atuttle commented Oct 29, 2015

@atuttle
Copy link
Owner Author

@atuttle atuttle commented Oct 29, 2015

Re-opening so that I remember to add this bug+fix to the release notes.

@atuttle atuttle reopened this Oct 29, 2015
@atuttle atuttle closed this Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.