resolves #253 #255

Merged
merged 1 commit into from Jan 26, 2015

Projects

None yet

2 participants

@guillaume-boivin
Contributor

Added exception thrown when uri or uri alias is not starting with a forward slash, and added the tests accordingly. Changed the Dashboard to show this new error.

@atuttle atuttle added this to the Taffy 3.1 milestone Jan 26, 2015
@atuttle atuttle commented on the diff Jan 26, 2015
tests/resources/uriAliasDoesntBeginWithForwardSlash.cfc
@@ -0,0 +1,7 @@
+<cfcomponent extends="taffy.core.resource" taffy:uri="/uriWithForwardSlash{,},uriAliasWithoutFowardSlash">
@atuttle
atuttle Jan 26, 2015 Owner

What's the {,} for?

@guillaume-boivin
guillaume-boivin Jan 26, 2015 Contributor

To make sure that if the comma escaping with brackets functionnality breaks in splitURIs(), it doesn't break this one too. Could put it in another test case as it's not obvious I'm implicitely testing this too.

@atuttle atuttle merged commit fd2b692 into atuttle:master Jan 26, 2015
@guillaume-boivin guillaume-boivin deleted the guillaume-boivin:shouldComplainWhenURIDoesntBeginWithLeadingSlash branch Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment