New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 277 recursively resolving dependencies #280

Merged
merged 3 commits into from Jul 13, 2015

Conversation

Projects
None yet
2 participants
@neoneo
Contributor

neoneo commented Jul 12, 2015

I've opted for passing the external beanfactory into Taffy's factory, and let getBean() ultimately check the external factory for the bean. If you have any remarks about the changes, please let me know.

Show outdated Hide outdated core/factory.cfc
@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Jul 13, 2015

Owner

I really like your approach of passing the external factory into Taffy's factory -- that makes a heck of a lot of sense! Just one note (see the line comment) about compatibility. This is going to be a great addition. Thanks so much!

Owner

atuttle commented Jul 13, 2015

I really like your approach of passing the external factory into Taffy's factory -- that makes a heck of a lot of sense! Just one note (see the line comment) about compatibility. This is going to be a great addition. Thanks so much!

@neoneo

This comment has been minimized.

Show comment
Hide comment
@neoneo

neoneo Jul 13, 2015

Contributor

Thanks for your feedback! Do you want me to fix those isNull's? Will do that later today.

Contributor

neoneo commented Jul 13, 2015

Thanks for your feedback! Do you want me to fix those isNull's? Will do that later today.

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Jul 13, 2015

Owner

Yes please! Just make the appropriate changes and push to the same branch of your repo. That will automatically update this PR.

Owner

atuttle commented Jul 13, 2015

Yes please! Just make the appropriate changes and push to the same branch of your repo. That will automatically update this PR.

@neoneo

This comment has been minimized.

Show comment
Hide comment
@neoneo

neoneo Jul 13, 2015

Contributor

I replaced the isNull calls with calls to structKeyExists (I like that better than isDefined), plus one or two minor changes (one of those is also a CF8 compat issue I believe).

Contributor

neoneo commented Jul 13, 2015

I replaced the isNull calls with calls to structKeyExists (I like that better than isDefined), plus one or two minor changes (one of those is also a CF8 compat issue I believe).

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Jul 13, 2015

Owner

Awesome. I'm going to go ahead and merge it in so that it can be in the bleeding edge downloads, but it won't be included in an official release until 3.1.

Owner

atuttle commented Jul 13, 2015

Awesome. I'm going to go ahead and merge it in so that it can be in the bleeding edge downloads, but it won't be included in an official release until 3.1.

atuttle added a commit that referenced this pull request Jul 13, 2015

Merge pull request #280 from neoneo/issue-277
Issue 277 recursively resolving dependencies

@atuttle atuttle merged commit 1e83bfe into atuttle:master Jul 13, 2015

@atuttle atuttle added this to the Taffy 3.1 milestone Jul 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment