New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify check for /resources mapping to support Railo/Lucee #290

Merged
merged 2 commits into from Aug 17, 2015

Conversation

Projects
None yet
2 participants
@tonyjunkes
Contributor

tonyjunkes commented Aug 16, 2015

Replaced coldfusion.server.ServiceFactory.getRuntimeService.getMappings() with directoryExists() as the ServiceFactory class is not implemented in Railo and Lucee.

Modify check for /resources mapping to support Railo/Lucee
Replaced coldfusion.server.ServiceFactory.getRuntimeService.getMappings() with directoryExists() as the ServiceFactory class is not implemented in Railo and Lucee.
@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Aug 16, 2015

Owner

This could actually be expanded to take over the entire <cfif> block -- no need to check this.mappings. Mind making that change too? Just push it to your master branch and it'll be added here automatically.

Owner

atuttle commented Aug 16, 2015

This could actually be expanded to take over the entire <cfif> block -- no need to check this.mappings. Mind making that change too? Just push it to your master branch and it'll be added here automatically.

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Aug 16, 2015

Contributor

I meant to inquire about that. Good call.

Contributor

tonyjunkes commented Aug 16, 2015

I meant to inquire about that. Good call.

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Aug 17, 2015

Owner

Looks great, thanks!

Owner

atuttle commented Aug 17, 2015

Looks great, thanks!

atuttle added a commit that referenced this pull request Aug 17, 2015

Merge pull request #290 from cfchef/master
Modify check for /resources mapping to support Railo/Lucee

@atuttle atuttle merged commit 072eaf1 into atuttle:master Aug 17, 2015

@atuttle atuttle added this to the Taffy 3.1 milestone Aug 17, 2015

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Aug 17, 2015

Owner

And now your face is on taffy.io ;)

Owner

atuttle commented Aug 17, 2015

And now your face is on taffy.io ;)

@tonyjunkes

This comment has been minimized.

Show comment
Hide comment
@tonyjunkes

tonyjunkes Aug 17, 2015

Contributor

Cheers! Glad I could help. 😄

Contributor

tonyjunkes commented Aug 17, 2015

Cheers! Glad I could help. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment