New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed potentially invalid characters from html div id #272

Merged
merged 1 commit into from Apr 30, 2015

Conversation

Projects
None yet
2 participants
@dhughes
Contributor

dhughes commented Apr 30, 2015

Removed potentially invalid characters from html div id to allow the test form to be used when the bean name contains unusual characters.

The bean names for services in my application were named after their rest path. IE:

<bean id="/example/status" class="com.foo.bar.rest.example.status" />

The front slashes in the bean name were causing the a tag and the associated div tags to use invalid ids/names. I used a regex to reduce the generated ID to only use alphanumeric characters and underscore. This resolved the problem.

dhughes
Removed potentially invalid characters from html div id to allow the …
…test form to be used when the bean name contains unusual characters
@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Apr 30, 2015

Owner

Thanks Doug!

Owner

atuttle commented Apr 30, 2015

Thanks Doug!

atuttle added a commit that referenced this pull request Apr 30, 2015

Merge pull request #272 from dhughes/master
Removed potentially invalid characters from html div id

@atuttle atuttle merged commit 1e38c89 into atuttle:master Apr 30, 2015

@atuttle atuttle added this to the Taffy 3.1 milestone Apr 30, 2015

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Apr 30, 2015

Owner

By the way, I see that you made your changes in master for this PR. You may want to avoid that in the future: http://fusiongrokker.com/post/github-tip-for-your-first-pull-request

Owner

atuttle commented Apr 30, 2015

By the way, I see that you made your changes in master for this PR. You may want to avoid that in the future: http://fusiongrokker.com/post/github-tip-for-your-first-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment