Removed potentially invalid characters from html div id #272

Merged
merged 1 commit into from Apr 30, 2015

Projects

None yet

2 participants

@dhughes
Contributor
dhughes commented Apr 30, 2015

Removed potentially invalid characters from html div id to allow the test form to be used when the bean name contains unusual characters.

The bean names for services in my application were named after their rest path. IE:

<bean id="/example/status" class="com.foo.bar.rest.example.status" />

The front slashes in the bean name were causing the a tag and the associated div tags to use invalid ids/names. I used a regex to reduce the generated ID to only use alphanumeric characters and underscore. This resolved the problem.

dhughes Removed potentially invalid characters from html div id to allow the …
…test form to be used when the bean name contains unusual characters
a1aa859
@atuttle
Owner
atuttle commented Apr 30, 2015

Thanks Doug!

@atuttle atuttle merged commit 1e38c89 into atuttle:master Apr 30, 2015
@atuttle atuttle added this to the Taffy 3.1 milestone Apr 30, 2015
@atuttle
Owner
atuttle commented Apr 30, 2015

By the way, I see that you made your changes in master for this PR. You may want to avoid that in the future: http://fusiongrokker.com/post/github-tip-for-your-first-pull-request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment