Fix of import and export and use app_id if environment configured #3

Merged
merged 6 commits into from Aug 18, 2012

Projects

None yet

3 participants

@rafaelp
rafaelp commented Aug 10, 2012

You were using Date.today as hash key to store rates for a specific date.
The problem is that after exporting to a string and importing again the key never returns as a Date object.
So I changed the code to use string as hash key.

@rates[date.to_s]

I've written tests to all implementations.

@travisbot

This pull request passes (merged 0989da9 into fc3fe5c).

@travisbot

This pull request passes (merged de96f1b into fc3fe5c).

@atwam
Owner
atwam commented Aug 18, 2012

Sorry, just got back from holidays.
Sounds good to me, will release a new gem version asap.

@atwam atwam merged commit c318a93 into atwam:master Aug 18, 2012

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment