Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding esc_url to address potential security issue #1

Merged
merged 1 commit into from Mar 9, 2016

Conversation

sdunham
Copy link

@sdunham sdunham commented Apr 27, 2015

The send_welcome_email_url() function doesn't use esc_url() on the output of add_query_arg(), which is the suggested fix for plugins which were affected by the WP 4.1.2 Security Release. You do pass it to wp_nonce_url(), which uses esc_html(). But this may not be enough to address the security issue.

See this post for details: https://blog.sucuri.net/2015/04/security-advisory-xss-vulnerability-affecting-multiple-wordpress-plugins.html

atwellpub added a commit that referenced this pull request Mar 9, 2016
Adding esc_url to address potential security issue
@atwellpub atwellpub merged commit ab006d5 into atwellpub:master Mar 9, 2016
@atwellpub
Copy link
Owner

Thank you

atwellpub pushed a commit that referenced this pull request Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants