Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADM-384 Mock Server for Config #151

Merged
merged 3 commits into from
Mar 1, 2023
Merged

ADM-384 Mock Server for Config #151

merged 3 commits into from
Mar 1, 2023

Conversation

bhan-tw
Copy link

@bhan-tw bhan-tw commented Feb 22, 2023

🍐 with @Eason-T

Summary

Mock the 3rd party services for config using stubby4j.
The requests and responses are all setup, the mock server can run locally.

TODO

Need to config docker and github actions and deploy to AWS

@codacy-production
Copy link

codacy-production bot commented Feb 22, 2023

Coverage summary from Codacy

Merging #151 (a6c233a) into main (8e50a1c) - See PR on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8e50a1c) 245 245 100.00%
Head commit (a6c233a) 245 (+0) 245 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#151) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

environment:
YAML_CONFIG: stubs.yaml
LOCATION: 0.0.0.0
STUBS_PORT: 8882
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change port to 4323, coc we use 4321 and 4322

@guzhongren guzhongren merged commit ebec3f7 into main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants