Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Systematically #include "config.h". Better fix for #256.

  • Loading branch information...
commit 87efc0902226b1b15486f6cfbdbc45ba4fa790ce 1 parent c24265e
@jlindgren90 jlindgren90 authored
Showing with 12 additions and 107 deletions.
  1. +0 −6 acinclude.m4
  2. +5 −0 configure.ac
  3. +0 −2  src/audacious/adder.c
  4. +0 −2  src/audacious/chardet.c
  5. +0 −2  src/audacious/dbus.c
  6. +0 −2  src/audacious/drct.c
  7. +0 −2  src/audacious/equalizer_preset.c
  8. +0 −2  src/audacious/fft.c
  9. +0 −2  src/audacious/main.c
  10. +2 −0  src/audacious/mpris-signals.c
  11. +0 −2  src/audacious/playback.c
  12. +0 −2  src/audacious/playlist-files.c
  13. +0 −2  src/audacious/playlist-new.c
  14. +0 −2  src/audacious/plugin-preferences.c
  15. +0 −2  src/audacious/pluginenum.c
  16. +0 −2  src/audacious/signals.c
  17. +0 −2  src/audacious/ui_albumart.c
  18. +0 −2  src/audacious/ui_preferences.c
  19. +0 −2  src/audacious/util.c
  20. +0 −2  src/libaudclient/audctrl.c
  21. +0 −2  src/libaudcore/audio.c
  22. +0 −2  src/libaudcore/audstrings.c
  23. +0 −2  src/libaudcore/eventqueue.c
  24. +0 −2  src/libaudcore/hook.c
  25. +0 −2  src/libaudcore/index.c
  26. +0 −2  src/libaudcore/strpool.c
  27. +0 −2  src/libaudcore/tuple.c
  28. +5 −7 src/libaudcore/vfs.c
  29. +0 −2  src/libaudcore/vfs_async.c
  30. +0 −2  src/libaudcore/vfs_common.c
  31. +0 −2  src/libaudgui/about.c
  32. +0 −2  src/libaudgui/confirm.c
  33. +0 −2  src/libaudgui/effects-menu.c
  34. +0 −2  src/libaudgui/equalizer.c
  35. +0 −2  src/libaudgui/icons-stock.c
  36. +0 −2  src/libaudgui/iface-menu.c
  37. +0 −2  src/libaudgui/infopopup.c
  38. +0 −2  src/libaudgui/infowin.c
  39. +0 −2  src/libaudgui/init.c
  40. +0 −2  src/libaudgui/jump-to-time.c
  41. +0 −2  src/libaudgui/list.c
  42. +0 −2  src/libaudgui/playlists.c
  43. +0 −2  src/libaudgui/queue-manager.c
  44. +0 −2  src/libaudgui/ui_fileopener.c
  45. +0 −2  src/libaudgui/ui_jumptotrack.c
  46. +0 −2  src/libaudgui/ui_jumptotrack_cache.c
  47. +0 −2  src/libaudgui/ui_playlist_manager.c
  48. +0 −2  src/libaudgui/urilist.c
  49. +0 −2  src/libaudgui/url-opener.c
  50. +0 −2  src/libaudgui/util.c
  51. +0 −2  src/libaudtag/audtag.c
View
6 acinclude.m4
@@ -178,12 +178,6 @@ case "$target" in
;;
esac
-dnl Large file support is sensitive to header order
-dnl ===============================================
-AH_BOTTOM([#ifdef _SYS_TYPES_H
-#error "config.h" must be #included before <sys/types.h>
-#endif])
-
dnl Checks for various programs
dnl ===========================
AUD_CHECK_GNU_MAKE
View
5 configure.ac
@@ -267,6 +267,11 @@ AUDACIOUS_DEFINES="$AUDACIOUS_DEFINES -DHARDCODE_ICONFILE=\\\"${datarootdir}/pix
AC_SUBST([AUDACIOUS_DEFINES])
+dnl Reliably #include "config.h" (for large file support)
+dnl =====================================================
+CPPFLAGS="$CPPFLAGS -include config.h"
+
+
### ---------------------------------------------------------------------------
dnl Output configuration files
dnl ==========================
View
2  src/audacious/adder.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <dirent.h>
#include <pthread.h>
#include <string.h>
View
2  src/audacious/chardet.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <string.h>
#include <libaudcore/audstrings.h>
View
2  src/audacious/dbus.c
@@ -19,8 +19,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <string.h>
View
2  src/audacious/drct.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <libaudcore/hook.h>
#include <libaudcore/vfs.h>
View
2  src/audacious/equalizer_preset.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <string.h>
View
2  src/audacious/fft.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <complex.h>
#include <math.h>
View
2  src/audacious/main.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <errno.h>
#include <fcntl.h>
#include <stdlib.h>
View
2  src/audacious/mpris-signals.c
@@ -19,6 +19,8 @@
#ifdef USE_DBUS
+#include <libaudcore/hook.h>
+
#include "dbus-service.h"
#include "main.h"
View
2  src/audacious/playback.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
#include <string.h>
View
2  src/audacious/playlist-files.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <libaudcore/audstrings.h>
View
2  src/audacious/playlist-new.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
View
2  src/audacious/plugin-preferences.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <libaudgui/libaudgui-gtk.h>
#include "i18n.h"
View
2  src/audacious/pluginenum.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <assert.h>
#include <errno.h>
#include <glib.h>
View
2  src/audacious/signals.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <pthread.h>
#include <signal.h>
View
2  src/audacious/ui_albumart.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <string.h>
View
2  src/audacious/ui_preferences.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <string.h>
#include <gdk/gdkkeysyms.h>
View
2  src/audacious/util.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <dirent.h>
#include <unistd.h>
View
2  src/libaudclient/audctrl.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <stdlib.h>
#include <glib.h>
#include <string.h>
View
2  src/libaudcore/audio.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <stdint.h>
#include <math.h>
View
2  src/libaudcore/audstrings.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <limits.h>
#include <math.h>
#include <stdio.h>
View
2  src/libaudcore/eventqueue.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
#include <string.h>
View
2  src/libaudcore/hook.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
View
2  src/libaudcore/index.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <stdlib.h>
#include <string.h>
View
2  src/libaudcore/strpool.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
#include <stdarg.h>
View
2  src/libaudcore/tuple.c
@@ -23,8 +23,6 @@
* @brief Basic Tuple handling API.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
#include <stdio.h>
View
12 src/libaudcore/vfs.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <inttypes.h>
@@ -413,32 +411,32 @@ vfs_file_test(const char * path, int test)
char * path2 = uri_to_filename (path);
if (! path2)
return FALSE;
-
+
#ifdef S_ISLNK
if (test & VFS_IS_SYMLINK)
{
struct stat st;
if (lstat (path2, & st) < 0)
return FALSE;
-
+
if (S_ISLNK (st.st_mode))
test &= ~VFS_IS_SYMLINK;
}
#endif
-
+
if (test & (VFS_IS_REGULAR | VFS_IS_DIR | VFS_IS_EXECUTABLE | VFS_EXISTS))
{
struct stat st;
if (stat (path2, & st) < 0)
return FALSE;
-
+
if (S_ISREG (st.st_mode))
test &= ~VFS_IS_REGULAR;
if (S_ISDIR (st.st_mode))
test &= ~VFS_IS_DIR;
if (st.st_mode & S_IXUSR)
test &= ~VFS_IS_EXECUTABLE;
-
+
test &= ~VFS_EXISTS;
}
View
2  src/libaudcore/vfs_async.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <pthread.h>
View
2  src/libaudcore/vfs_common.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <glib/gprintf.h>
#include <stdio.h>
View
2  src/libaudgui/about.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/i18n.h>
View
2  src/libaudgui/confirm.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/i18n.h>
View
2  src/libaudgui/effects-menu.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <audacious/i18n.h>
#include <audacious/plugin.h>
#include <audacious/plugins.h>
View
2  src/libaudgui/equalizer.c
@@ -23,8 +23,6 @@
* sign of the values we get.
*/
-#include "config.h"
-
#include <math.h>
#include <audacious/i18n.h>
View
2  src/libaudgui/icons-stock.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/misc.h>
View
2  src/libaudgui/iface-menu.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/plugins.h>
View
2  src/libaudgui/infopopup.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <string.h>
View
2  src/libaudgui/infowin.c
@@ -18,8 +18,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <stdarg.h>
#include <stdlib.h>
View
2  src/libaudgui/init.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <audacious/misc.h>
#include <audacious/playlist.h>
#include <libaudcore/hook.h>
View
2  src/libaudgui/jump-to-time.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <stdio.h>
#include <gtk/gtk.h>
View
2  src/libaudgui/list.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <stddef.h>
#include <gtk/gtk.h>
View
2  src/libaudgui/playlists.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/i18n.h>
View
2  src/libaudgui/queue-manager.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gdk/gdkkeysyms.h>
#include <gtk/gtk.h>
View
2  src/libaudgui/ui_fileopener.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/i18n.h>
View
2  src/libaudgui/ui_jumptotrack.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gdk/gdkkeysyms.h>
#include <gtk/gtk.h>
View
2  src/libaudgui/ui_jumptotrack_cache.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <stdlib.h>
View
2  src/libaudgui/ui_playlist_manager.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <string.h>
#include <gtk/gtk.h>
View
2  src/libaudgui/urilist.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <string.h>
#include <glib.h>
View
2  src/libaudgui/url-opener.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <gtk/gtk.h>
#include <audacious/drct.h>
View
2  src/libaudgui/util.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <string.h>
#include <gdk/gdkkeysyms.h>
View
2  src/libaudtag/audtag.c
@@ -17,8 +17,6 @@
* the use of this software.
*/
-#include "config.h"
-
#include <glib.h>
#include <libaudcore/tuple.h>
Please sign in to comment.
Something went wrong with that request. Please try again.